Conversation
- Introduced utility for consistent revenue share calculations. - Updated parameter documentation in , , and classes to clarify revenue share constraints. - Refactored methods to utilize the new revenue share utility, ensuring type safety and clarity. - Added unit tests for revenue share validation and address validation in .
bonnie57
requested review from
AndyBoWu,
edisonz0718,
limengformal,
lucas2brh and
sebsadface
as code owners
bonnie57
changed the title
…IPAsset class, enhance documentation, and add unit tests for register_derivative method
…hare parameters in License class, update unit tests for default values
lucas2brh
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
Unit test
Integration test
